Json stringify object measurements
#1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey you mentioned an older commit, what commit are you using to build and test this out? We can consider rolling the web gui backwards to that point if its really necessary. I hesitate to take this and #1035 until the changes (as in the web_gui with and without the changes) can be built at current master. |
|
That would have been 341aa86 I believe |
This was referenced Sep 20, 2022
Merged
|
@glados-verma @dbhatman Now that the web gui is buildable again it would be great if you could consider this one as well. |
lalten
force-pushed
the
laurenz/json-stringify-measurements
branch
from
af8ec0e to
a8fa970
Compare
glados-verma
previously approved these changes
Oct 12, 2022
This change will e.g. make the values of `typing.NamedTuple`s visible in the Web UI. Before this change they were displayed as `[object Object]`. I believe the measurements are guaranteed to be json-serializable because they are coming in via the websocket transport, which uses json already.
lalten
force-pushed
the
laurenz/json-stringify-measurements
branch
from
dd8798e to
ce7387c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will e.g. make the values of
typing.NamedTuples visible in the Web UI. Before this change they were displayed as[object Object]. I believe the measurements are guaranteed to be json-serializable because they are coming in via the websocket transport, which uses json already.In the second commit, I modify the web ui to "pretty-print" the values as well so e.g. dictionaries are not all on one line anymore. See screenshot:
This change is